Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is. (Closed)

Created:
9 years, 2 months ago by Ami GONE FROM CHROMIUM
Modified:
9 years, 1 month ago
Reviewers:
tony, Avi (use Gerrit), jam
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, jam, annacc+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is. BUG=101375 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107471

Patch Set 1 #

Patch Set 2 : fix test callers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M content/renderer/render_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/webmediaplayer_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/glue/webmediaplayer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/support/webkit_support.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Ami GONE FROM CHROMIUM
9 years, 2 months ago (2011-10-24 19:35:54 UTC) #1
Avi (use Gerrit)
LGTM
9 years, 2 months ago (2011-10-24 20:30:53 UTC) #2
Ami GONE FROM CHROMIUM
Darin: please OWNERS-review. Thanks!
9 years, 2 months ago (2011-10-24 22:49:18 UTC) #3
Ami GONE FROM CHROMIUM
darin: ping?
9 years, 1 month ago (2011-10-26 17:32:14 UTC) #4
Avi (use Gerrit)
On 2011/10/26 17:32:14, Ami Fischman wrote: > darin: ping? Can we find alternate owners? We ...
9 years, 1 month ago (2011-10-26 21:54:53 UTC) #5
Ami GONE FROM CHROMIUM
jam: please OWNERS-review content/renderer tony: please OWNERS-review webkit/... Thanks.
9 years, 1 month ago (2011-10-26 22:08:51 UTC) #6
tony
LGTM
9 years, 1 month ago (2011-10-26 22:11:59 UTC) #7
jam
lgtm
9 years, 1 month ago (2011-10-26 22:26:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/8382012/2001
9 years, 1 month ago (2011-10-26 22:29:19 UTC) #9
commit-bot: I haz the power
9 years, 1 month ago (2011-10-26 23:46:56 UTC) #10 
Change committed as 107471

Powered by Google App Engine
This is Rietveld 408576698