content/renderer/render_view_impl.cc - Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test callers Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index ac6f1aa48a72dccac3b044bffaaf2e3d54d53193..f6115450ce3ce7370e38affd2d30083625a80490 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1947,7 +1947,7 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(

scoped_ptr<webkit_glue::WebMediaPlayerImpl> result(

new webkit_glue::WebMediaPlayerImpl(client,

- this,

+ AsWeakPtr(),

collection.release(),

message_loop_factory.release(),

media_stream_impl_.get(),

« no previous file with comments | « no previous file | webkit/glue/webmediaplayer_impl.h » ('j') | no next file with comments »