webkit/glue/webmediaplayer_impl.cc - Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webmediaplayer_impl.cc

Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test callers Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/webmediaplayer_impl.cc

diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc

index a7d687876d69bbdb15c842e62a203092724141de..62c9c5d5846fc80dd9ce7733509590fe8116f6ec 100644

--- a/webkit/glue/webmediaplayer_impl.cc

+++ b/webkit/glue/webmediaplayer_impl.cc

@@ -98,7 +98,7 @@ namespace webkit_glue {

WebMediaPlayerImpl::WebMediaPlayerImpl(

WebKit::WebMediaPlayerClient* client,

- WebMediaPlayerDelegate* delegate,

+ base::WeakPtr<WebMediaPlayerDelegate> delegate,

media::FilterCollection* collection,

media::MessageLoopFactory* message_loop_factory,

MediaStreamClient* media_stream_client,

« no previous file with comments | « webkit/glue/webmediaplayer_impl.h ('k') | webkit/support/webkit_support.cc » ('j') | no next file with comments »