webkit/glue/webmediaplayer_impl.h - Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webmediaplayer_impl.h

Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix test callers Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/webmediaplayer_impl.h

diff --git a/webkit/glue/webmediaplayer_impl.h b/webkit/glue/webmediaplayer_impl.h

index ea19d583524a5d58bf4691cee787cc0e738efea0..34970b9060833408db1f62a387c229441e48aae4 100644

--- a/webkit/glue/webmediaplayer_impl.h

+++ b/webkit/glue/webmediaplayer_impl.h

@@ -105,7 +105,7 @@ class WebMediaPlayerImpl

// Callers must call |Initialize()| before they can use the object.

WebMediaPlayerImpl(WebKit::WebMediaPlayerClient* client,

- WebMediaPlayerDelegate* delegate,

+ base::WeakPtr<WebMediaPlayerDelegate> delegate,

media::FilterCollection* collection,

media::MessageLoopFactory* message_loop_factory,

MediaStreamClient* media_stream_client,

@@ -259,7 +259,7 @@ class WebMediaPlayerImpl

scoped_refptr<WebMediaPlayerProxy> proxy_;

- WebMediaPlayerDelegate* delegate_;

+ base::WeakPtr<WebMediaPlayerDelegate> delegate_;

MediaStreamClient* media_stream_client_;

« no previous file with comments | « content/renderer/render_view_impl.cc ('k') | webkit/glue/webmediaplayer_impl.cc » ('j') | no next file with comments »