Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: webkit/support/webkit_support.cc

Issue 8382012: Fix shutdown crash when WebMediaPlayerImpl is destroyed after RenderViewImpl is. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix test callers Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/glue/webmediaplayer_impl.cc ('k') | webkit/tools/test_shell/test_webview_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/support/webkit_support.cc
diff --git a/webkit/support/webkit_support.cc b/webkit/support/webkit_support.cc
index 641241905ace758edb99a77ba8c4935c52215f24..214c41736bcaac572b745e29a231f284f10c58d4 100644
--- a/webkit/support/webkit_support.cc
+++ b/webkit/support/webkit_support.cc
@@ -323,12 +323,13 @@ WebKit::WebMediaPlayer* CreateMediaPlayer(WebFrame* frame,
collection->AddVideoRenderer(video_renderer);
scoped_ptr<webkit_glue::WebMediaPlayerImpl> result(
- new webkit_glue::WebMediaPlayerImpl(client,
- NULL,
- collection.release(),
- message_loop_factory.release(),
- NULL,
- new media::MediaLog()));
+ new webkit_glue::WebMediaPlayerImpl(
+ client,
+ base::WeakPtr<webkit_glue::WebMediaPlayerDelegate>(),
+ collection.release(),
+ message_loop_factory.release(),
+ NULL,
+ new media::MediaLog()));
if (!result->Initialize(frame, false, video_renderer)) {
return NULL;
}
« no previous file with comments | « webkit/glue/webmediaplayer_impl.cc ('k') | webkit/tools/test_shell/test_webview_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698