base/win: small improvement to RegKey API.

base/win: small improvement to RegKey API.

- Rename ValueExists() to HasValue().
- Rename ValueCount()  to GetValueCount().
- Rename ReadName()    to GetValueNameAt().

R=maruel@chromium.org,willchan@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106074

[tfarina, 2011-10-18 03:19:25]

Marc, you have reviewed my patches to RegKey when I cleaned it up.

Will for OWNERS approve.

I'm trying to make it more closer to RegKey API from Omaha.

http://code.google.com/p/omaha/source/browse/trunk/base/reg_key.h

PTAL! thanks!

[M-A Ruel, 2011-10-18 03:28:05]

ok, lgtm

http://codereview.chromium.org/8337006/diff/1/base/win/registry.h
File base/win/registry.h (right):

http://codereview.chromium.org/8337006/diff/1/base/win/registry.h#newcode45
base/win/registry.h:45: // Close this reg key.
Closes

[tfarina, 2011-10-18 03:45:07]

http://codereview.chromium.org/8337006/diff/1/base/win/registry.h
File base/win/registry.h (right):

http://codereview.chromium.org/8337006/diff/1/base/win/registry.h#newcode45
base/win/registry.h:45: // Close this reg key.
On 2011/10/18 03:28:06, Marc-Antoine Ruel wrote:
> Closes

Done.

[willchan no longer on Chromium, 2011-10-18 04:24:44]

lgtm

[grt (UTC plus 2), 2011-10-18 15:00:00]

drive-by comment nits.

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h
File base/win/registry.h (right):

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h#newcode42
base/win/registry.h:42: // Opens an existing reg key, given the full key name.
full_key_name and this comment are misleading.  This method opens up a subkey of
|this| object's currently open key.  relative_key_name or subkey would both be
more appropriate, since the name is relative to the currently open key.

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h#newcode49
base/win/registry.h:49: bool HasValue(const wchar_t* value_name) const;
The following is more accurate:
// Returns false if this key does not have the specified value, or if an error
occurs while attempting to access it.

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h#newcode51
base/win/registry.h:51: // Returns the number of values for this key.
// Returns the number of values for this key, or 0 if the number cannot be
determined.

[tfarina, 2011-10-18 15:47:04]

On 2011/10/18 15:00:00, grt wrote:
> drive-by comment nits.
> 
Thank you for the comments!

Applied everything, committing after it passes trybots.

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h
File base/win/registry.h (right):

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h#newcode42
base/win/registry.h:42: // Opens an existing reg key, given the full key name.
On 2011/10/18 15:00:00, grt wrote:
> full_key_name and this comment are misleading.  This method opens up a subkey
of
> |this| object's currently open key.  relative_key_name or subkey would both be
> more appropriate, since the name is relative to the currently open key.

Done.

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h#newcode49
base/win/registry.h:49: bool HasValue(const wchar_t* value_name) const;
On 2011/10/18 15:00:00, grt wrote:
> The following is more accurate:
> // Returns false if this key does not have the specified value, or if an error
> occurs while attempting to access it.

Done.

http://codereview.chromium.org/8337006/diff/4001/base/win/registry.h#newcode51
base/win/registry.h:51: // Returns the number of values for this key.
On 2011/10/18 15:00:00, grt wrote:
> // Returns the number of values for this key, or 0 if the number cannot be
> determined.

Done.