chrome/installer/util/google_update_settings.cc - Issue 8337006: base/win: small improvement to RegKey API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/google_update_settings.cc

Issue 8337006: base/win: small improvement to RegKey API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: apply grt comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/google_update_settings.cc

diff --git a/chrome/installer/util/google_update_settings.cc b/chrome/installer/util/google_update_settings.cc

index b79e61a52bb6a121c350a82b0365e5049a243c11..babd396e6909a6a32ddc62505da6e1a723644525 100644

--- a/chrome/installer/util/google_update_settings.cc

+++ b/chrome/installer/util/google_update_settings.cc

@@ -102,7 +102,7 @@ bool RemoveGoogleUpdateStrKey(const wchar_t* const name) {

BrowserDistribution* dist = BrowserDistribution::GetDistribution();

std::wstring reg_path = dist->GetStateKey();

RegKey key(HKEY_CURRENT_USER, reg_path.c_str(), KEY_READ | KEY_WRITE);

- if (!key.ValueExists(name))

+ if (!key.HasValue(name))

return true;

return (key.DeleteValue(name) == ERROR_SUCCESS);

}