chrome/installer/util/install_util.cc - Issue 8337006: base/win: small improvement to RegKey API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/install_util.cc

Issue 8337006: base/win: small improvement to RegKey API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: apply grt comments Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/install_util.cc

diff --git a/chrome/installer/util/install_util.cc b/chrome/installer/util/install_util.cc

index 158239701b8c42cb13262fcff4e8ab9fa880d2cf..acd38632f9c5d2ac10fdab615174e1d15222f6ce 100644

--- a/chrome/installer/util/install_util.cc

+++ b/chrome/installer/util/install_util.cc

@@ -375,7 +375,7 @@ bool InstallUtil::DeleteRegistryValue(HKEY reg_root,

const std::wstring& value_name) {

RegKey key(reg_root, key_path.c_str(), KEY_ALL_ACCESS);

VLOG(1) << "Deleting registry value " << value_name;

- if (key.ValueExists(value_name.c_str())) {

+ if (key.HasValue(value_name.c_str())) {

LONG result = key.DeleteValue(value_name.c_str());

if (result != ERROR_SUCCESS) {

LOG(ERROR) << "Failed to delete registry value: " << value_name