Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7227)

Unified Diff: chrome/installer/util/delete_reg_value_work_item_unittest.cc

Issue 8337006: base/win: small improvement to RegKey API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply grt comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/delete_reg_value_work_item_unittest.cc
diff --git a/chrome/installer/util/delete_reg_value_work_item_unittest.cc b/chrome/installer/util/delete_reg_value_work_item_unittest.cc
index 634ee421453b405e1b625e186db9b461b213adf6..f0fa53ef8b1e0d6c6f3cb5fa10ff5bf957476308 100644
--- a/chrome/installer/util/delete_reg_value_work_item_unittest.cc
+++ b/chrome/installer/util/delete_reg_value_work_item_unittest.cc
@@ -71,9 +71,9 @@ TEST_F(DeleteRegValueWorkItemTest, DeleteExistingValue) {
EXPECT_TRUE(work_item2->Do());
EXPECT_TRUE(work_item3->Do());
- EXPECT_FALSE(key.ValueExists(name_str.c_str()));
- EXPECT_FALSE(key.ValueExists(name_dword.c_str()));
- EXPECT_FALSE(key.ValueExists(name_empty.c_str()));
+ EXPECT_FALSE(key.HasValue(name_str.c_str()));
+ EXPECT_FALSE(key.HasValue(name_dword.c_str()));
+ EXPECT_FALSE(key.HasValue(name_empty.c_str()));
work_item1->Rollback();
work_item2->Rollback();
@@ -104,8 +104,8 @@ TEST_F(DeleteRegValueWorkItemTest, DeleteNonExistentValue) {
key.Create(HKEY_CURRENT_USER, parent_key.c_str(), KEY_READ | KEY_WRITE));
std::wstring name_str(L"name_str");
std::wstring name_dword(L"name_dword");
- EXPECT_FALSE(key.ValueExists(name_str.c_str()));
- EXPECT_FALSE(key.ValueExists(name_dword.c_str()));
+ EXPECT_FALSE(key.HasValue(name_str.c_str()));
+ EXPECT_FALSE(key.HasValue(name_dword.c_str()));
scoped_ptr<DeleteRegValueWorkItem> work_item1(
WorkItem::CreateDeleteRegValueWorkItem(HKEY_CURRENT_USER, parent_key,
@@ -117,12 +117,12 @@ TEST_F(DeleteRegValueWorkItemTest, DeleteNonExistentValue) {
EXPECT_TRUE(work_item1->Do());
EXPECT_TRUE(work_item2->Do());
- EXPECT_FALSE(key.ValueExists(name_str.c_str()));
- EXPECT_FALSE(key.ValueExists(name_dword.c_str()));
+ EXPECT_FALSE(key.HasValue(name_str.c_str()));
+ EXPECT_FALSE(key.HasValue(name_dword.c_str()));
work_item1->Rollback();
work_item2->Rollback();
- EXPECT_FALSE(key.ValueExists(name_str.c_str()));
- EXPECT_FALSE(key.ValueExists(name_dword.c_str()));
+ EXPECT_FALSE(key.HasValue(name_str.c_str()));
+ EXPECT_FALSE(key.HasValue(name_dword.c_str()));
}
« no previous file with comments | « chrome/browser/background/background_mode_manager_win.cc ('k') | chrome/installer/util/google_update_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698