Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: base/win/registry_unittest.cc

Issue 8337006: base/win: small improvement to RegKey API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: apply grt comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/win/registry.cc ('k') | chrome/browser/autofill/autofill_ie_toolbar_import_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/win/registry.h" 5 #include "base/win/registry.h"
6 #include "testing/gtest/include/gtest/gtest.h" 6 #include "testing/gtest/include/gtest/gtest.h"
7 7
8 namespace base { 8 namespace base {
9 namespace win { 9 namespace win {
10 10
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 const wchar_t* kInt64ValueName = L"Int64Value"; 53 const wchar_t* kInt64ValueName = L"Int64Value";
54 const wchar_t* kStringData = L"string data"; 54 const wchar_t* kStringData = L"string data";
55 const DWORD kDWORDData = 0xdeadbabe; 55 const DWORD kDWORDData = 0xdeadbabe;
56 const int64 kInt64Data = 0xdeadbabedeadbabeLL; 56 const int64 kInt64Data = 0xdeadbabedeadbabeLL;
57 57
58 // Test value creation 58 // Test value creation
59 ASSERT_EQ(ERROR_SUCCESS, key.WriteValue(kStringValueName, kStringData)); 59 ASSERT_EQ(ERROR_SUCCESS, key.WriteValue(kStringValueName, kStringData));
60 ASSERT_EQ(ERROR_SUCCESS, key.WriteValue(kDWORDValueName, kDWORDData)); 60 ASSERT_EQ(ERROR_SUCCESS, key.WriteValue(kDWORDValueName, kDWORDData));
61 ASSERT_EQ(ERROR_SUCCESS, key.WriteValue(kInt64ValueName, &kInt64Data, 61 ASSERT_EQ(ERROR_SUCCESS, key.WriteValue(kInt64ValueName, &kInt64Data,
62 sizeof(kInt64Data), REG_QWORD)); 62 sizeof(kInt64Data), REG_QWORD));
63 EXPECT_EQ(3U, key.ValueCount()); 63 EXPECT_EQ(3U, key.GetValueCount());
64 EXPECT_TRUE(key.ValueExists(kStringValueName)); 64 EXPECT_TRUE(key.HasValue(kStringValueName));
65 EXPECT_TRUE(key.ValueExists(kDWORDValueName)); 65 EXPECT_TRUE(key.HasValue(kDWORDValueName));
66 EXPECT_TRUE(key.ValueExists(kInt64ValueName)); 66 EXPECT_TRUE(key.HasValue(kInt64ValueName));
67 67
68 // Test Read 68 // Test Read
69 std::wstring string_value; 69 std::wstring string_value;
70 DWORD dword_value = 0; 70 DWORD dword_value = 0;
71 int64 int64_value = 0; 71 int64 int64_value = 0;
72 ASSERT_EQ(ERROR_SUCCESS, key.ReadValue(kStringValueName, &string_value)); 72 ASSERT_EQ(ERROR_SUCCESS, key.ReadValue(kStringValueName, &string_value));
73 ASSERT_EQ(ERROR_SUCCESS, key.ReadValueDW(kDWORDValueName, &dword_value)); 73 ASSERT_EQ(ERROR_SUCCESS, key.ReadValueDW(kDWORDValueName, &dword_value));
74 ASSERT_EQ(ERROR_SUCCESS, key.ReadInt64(kInt64ValueName, &int64_value)); 74 ASSERT_EQ(ERROR_SUCCESS, key.ReadInt64(kInt64ValueName, &int64_value));
75 EXPECT_STREQ(kStringData, string_value.c_str()); 75 EXPECT_STREQ(kStringData, string_value.c_str());
76 EXPECT_EQ(kDWORDData, dword_value); 76 EXPECT_EQ(kDWORDData, dword_value);
77 EXPECT_EQ(kInt64Data, int64_value); 77 EXPECT_EQ(kInt64Data, int64_value);
78 78
79 // Make sure out args are not touched if ReadValue fails 79 // Make sure out args are not touched if ReadValue fails
80 const wchar_t* kNonExistent = L"NonExistent"; 80 const wchar_t* kNonExistent = L"NonExistent";
81 ASSERT_NE(ERROR_SUCCESS, key.ReadValue(kNonExistent, &string_value)); 81 ASSERT_NE(ERROR_SUCCESS, key.ReadValue(kNonExistent, &string_value));
82 ASSERT_NE(ERROR_SUCCESS, key.ReadValueDW(kNonExistent, &dword_value)); 82 ASSERT_NE(ERROR_SUCCESS, key.ReadValueDW(kNonExistent, &dword_value));
83 ASSERT_NE(ERROR_SUCCESS, key.ReadInt64(kNonExistent, &int64_value)); 83 ASSERT_NE(ERROR_SUCCESS, key.ReadInt64(kNonExistent, &int64_value));
84 EXPECT_STREQ(kStringData, string_value.c_str()); 84 EXPECT_STREQ(kStringData, string_value.c_str());
85 EXPECT_EQ(kDWORDData, dword_value); 85 EXPECT_EQ(kDWORDData, dword_value);
86 EXPECT_EQ(kInt64Data, int64_value); 86 EXPECT_EQ(kInt64Data, int64_value);
87 87
88 // Test delete 88 // Test delete
89 ASSERT_EQ(ERROR_SUCCESS, key.DeleteValue(kStringValueName)); 89 ASSERT_EQ(ERROR_SUCCESS, key.DeleteValue(kStringValueName));
90 ASSERT_EQ(ERROR_SUCCESS, key.DeleteValue(kDWORDValueName)); 90 ASSERT_EQ(ERROR_SUCCESS, key.DeleteValue(kDWORDValueName));
91 ASSERT_EQ(ERROR_SUCCESS, key.DeleteValue(kInt64ValueName)); 91 ASSERT_EQ(ERROR_SUCCESS, key.DeleteValue(kInt64ValueName));
92 EXPECT_EQ(0U, key.ValueCount()); 92 EXPECT_EQ(0U, key.GetValueCount());
93 EXPECT_FALSE(key.ValueExists(kStringValueName)); 93 EXPECT_FALSE(key.HasValue(kStringValueName));
94 EXPECT_FALSE(key.ValueExists(kDWORDValueName)); 94 EXPECT_FALSE(key.HasValue(kDWORDValueName));
95 EXPECT_FALSE(key.ValueExists(kInt64ValueName)); 95 EXPECT_FALSE(key.HasValue(kInt64ValueName));
96 } 96 }
97 } 97 }
98 98
99 } // namespace 99 } // namespace
100 100
101 } // namespace win 101 } // namespace win
102 } // namespace base 102 } // namespace base
OLDNEW
« no previous file with comments | « base/win/registry.cc ('k') | chrome/browser/autofill/autofill_ie_toolbar_import_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698