Convert SHA256_LENGTH from a constant-in-anonymous-enum to a static const. This defines the cons...

Convert SHA256_LENGTH from a constant-in-anonymous-enum to a static const.  This defines the constant where it's declared to preserve the existing readability.

Normally this makes things like DCHECK_EQ() unhappy, but when I'd originally tested this I didn't seem to need to make any changes due to that.  Will be watching the trybots...

The original motiviation for this change was to find a way to eliminate some cases of passing anonymous-typed values as template arguments (which happens when you use a value from the enum in e.g. EXPECT_EQ()), which is technically illegal in C++03, though we don't warn about it. Simply naming the enum would have done this, but in general naming enums used to declare constants like this is bizarre ("enum Constants { ... }"?).

BUG=92247
TEST=Compiles
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102369

[wtc, 2011-09-02 17:08:42]

LGTM!

http://codereview.chromium.org/7823004/diff/1/chrome/browser/extensions/conve...
File chrome/browser/extensions/convert_web_app.cc (right):

http://codereview.chromium.org/7823004/diff/1/chrome/browser/extensions/conve...
chrome/browser/extensions/convert_web_app.cc:52: crypto::kSHA256Length);
Nit: since 'raw' and crypto::kSHA256Length are related (buffer
and buffer length), it looks nicer to have them on the same
line.  Up to you.

http://codereview.chromium.org/7823004/diff/1/chrome/browser/safe_browsing/sa...
File chrome/browser/safe_browsing/safe_browsing_util.cc (left):

http://codereview.chromium.org/7823004/diff/1/chrome/browser/safe_browsing/sa...
chrome/browser/safe_browsing/safe_browsing_util.cc:534:
DCHECK_EQ(static_cast<size_t>(crypto::SHA256_LENGTH), sizeof(hash.full_hash));
The removal of these static_casts is good!

http://codereview.chromium.org/7823004/diff/1/crypto/sha2.h
File crypto/sha2.h (right):

http://codereview.chromium.org/7823004/diff/1/crypto/sha2.h#newcode19
crypto/sha2.h:19: static const size_t kSHA256Length = 32;  // length in bytes of
a SHA-256 hash
Question: is the 'static' necessary?

[wtc, 2011-09-02 17:37:14]

I found that base/sha1.h has an enumerator SHA1_LENGTH
that should be fixed in the same way to be consistent.

Since we are modifying code that uses base::SHA1_LENGTH
to deal with the DigiNotar CA incident, I suggest not
changing base/sha1.h until M16, to make it easier to
merge our DigiNotar patches to Stable and Beta branches.

[Peter Kasting, 2011-09-12 17:30:08]

On 2011/09/02 17:37:14, wtc wrote:
> I found that base/sha1.h has an enumerator SHA1_LENGTH
> that should be fixed in the same way to be consistent.

Have we landed all the DigiNotar stuff yet or is there more to come?  If we've
landed it all, I can go ahead and make this change, although I'd rather do it in
a separate patch if that's OK with you.

[wtc, 2011-09-12 19:37:39]

Yes, please make the SHA1_LENGTH change in a separate patch.

It is best to wait another week for the DigiNotar changes
to settle, but you can write the SHA1_LENGTH change and have
it reviewed first.