Convert SHA256_LENGTH from a constant-in-anonymous-enum to a static const. This defines the cons...

chrome/browser/safe_browsing/client_side_detection_service_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 #include <queue>
 #include <string>
 
 #include "base/callback.h"
 #include "base/logging.h"
@@ skipping 407 matching lines @@
 }
 
 TEST_F(ClientSideDetectionServiceTest, SetBadSubnets) {
   ClientSideModel model;
   ClientSideDetectionService::BadSubnetMap bad_subnets;
   ClientSideDetectionService::SetBadSubnets(model, &bad_subnets);
   EXPECT_EQ(0U, bad_subnets.size());
 
   // Bad subnets are skipped.
   ClientSideModel::IPSubnet* subnet = model.add_bad_subnet();
-  subnet->set_prefix(std::string(crypto::SHA256_LENGTH, '.'));
+  subnet->set_prefix(std::string(crypto::kSHA256Length, '.'));
   subnet->set_size(130);  // Invalid size.
 
   subnet = model.add_bad_subnet();
-  subnet->set_prefix(std::string(crypto::SHA256_LENGTH, '.'));
+  subnet->set_prefix(std::string(crypto::kSHA256Length, '.'));
   subnet->set_size(-1);  // Invalid size.
 
   subnet = model.add_bad_subnet();
   subnet->set_prefix(std::string(16, '.'));  // Invalid len.
   subnet->set_size(64);
 
   ClientSideDetectionService::SetBadSubnets(model, &bad_subnets);
   EXPECT_EQ(0U, bad_subnets.size());
 
   subnet = model.add_bad_subnet();
-  subnet->set_prefix(std::string(crypto::SHA256_LENGTH, '.'));
+  subnet->set_prefix(std::string(crypto::kSHA256Length, '.'));
   subnet->set_size(64);
 
   subnet = model.add_bad_subnet();
-  subnet->set_prefix(std::string(crypto::SHA256_LENGTH, ','));
+  subnet->set_prefix(std::string(crypto::kSHA256Length, ','));
   subnet->set_size(64);
 
   subnet = model.add_bad_subnet();
-  subnet->set_prefix(std::string(crypto::SHA256_LENGTH, '.'));
+  subnet->set_prefix(std::string(crypto::kSHA256Length, '.'));
   subnet->set_size(128);
 
   subnet = model.add_bad_subnet();
-  subnet->set_prefix(std::string(crypto::SHA256_LENGTH, '.'));
+  subnet->set_prefix(std::string(crypto::kSHA256Length, '.'));
   subnet->set_size(100);
 
   ClientSideDetectionService::SetBadSubnets(model, &bad_subnets);
   EXPECT_EQ(3U, bad_subnets.size());
   ClientSideDetectionService::BadSubnetMap::const_iterator it;
   std::string mask = std::string(8, '\xFF') + std::string(8, '\x00');
   EXPECT_TRUE(bad_subnets.count(mask));
-  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::SHA256_LENGTH, '.')));
-  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::SHA256_LENGTH, ',')));
+  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::kSHA256Length, '.')));
+  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::kSHA256Length, ',')));
 
   mask = std::string(16, '\xFF');
   EXPECT_TRUE(bad_subnets.count(mask));
-  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::SHA256_LENGTH, '.')));
+  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::kSHA256Length, '.')));
 
   mask = std::string(12, '\xFF') + "\xF0" + std::string(3, '\x00');
   EXPECT_TRUE(bad_subnets.count(mask));
-  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::SHA256_LENGTH, '.')));
+  EXPECT_TRUE(bad_subnets[mask].count(std::string(crypto::kSHA256Length, '.')));
 }
 
 TEST_F(ClientSideDetectionServiceTest, IsBadIpAddress) {
   ClientSideModel model;
   // IPv6 exact match for: 2620:0:1000:3103:21a:a0ff:fe10:786e.
   ClientSideModel::IPSubnet* subnet = model.add_bad_subnet();
   subnet->set_prefix(crypto::SHA256HashString(std::string(
       "\x26\x20\x00\x00\x10\x00\x31\x03\x02\x1a\xa0\xff\xfe\x10\x78\x6e", 16)));
   subnet->set_size(128);
 
@@ skipping 262 matching lines @@
         << "Non-model feature " << i;
   }
 
   // Also check the serialized forms in case there's a field that we forget
   // to add above.
   EXPECT_EQ(expected.SerializeAsString(),
             sanitized_request.SerializeAsString());
 }
 
 }  // namespace safe_browsing