Convert SHA256_LENGTH from a constant-in-anonymous-enum to a static const. This defines the cons...

chrome/browser/extensions/convert_web_app.cc

Index: chrome/browser/extensions/convert_web_app.cc
===================================================================
--- chrome/browser/extensions/convert_web_app.cc	(revision 98481)
+++ chrome/browser/extensions/convert_web_app.cc	(working copy)
@@ -46,12 +46,11 @@
 // auto-updated using ExtensionUpdater. But Chrome does notice updates to the
 // manifest and regenerates these extensions.
 std::string GenerateKey(const GURL& manifest_url) {
-  char raw[crypto::SHA256_LENGTH] = {0};
+  char raw[crypto::kSHA256Length] = {0};
   std::string key;
-  crypto::SHA256HashString(manifest_url.spec().c_str(),
-                           raw,
-                           crypto::SHA256_LENGTH);
-  base::Base64Encode(std::string(raw, crypto::SHA256_LENGTH), &key);
+  crypto::SHA256HashString(manifest_url.spec().c_str(), raw,
+                           crypto::kSHA256Length);

[wtc, 2011/09/02 17:08:42]

Nit: since 'raw' and crypto::kSHA256Length are related (buffer
and buffer length), it looks nicer to have them on the same
line.  Up to you.

+  base::Base64Encode(std::string(raw, crypto::kSHA256Length), &key);
   return key;
 }