Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4153)

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 7823004: Convert SHA256_LENGTH from a constant-in-anonymous-enum to a static const. This defines the cons... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_updater.cc
===================================================================
--- chrome/browser/extensions/extension_updater.cc (revision 98481)
+++ chrome/browser/extensions/extension_updater.cc (working copy)
@@ -795,10 +795,10 @@
void ExtensionUpdater::ProcessBlacklist(const std::string& data) {
DCHECK(alive_);
// Verify sha256 hash value.
- char sha256_hash_value[crypto::SHA256_LENGTH];
- crypto::SHA256HashString(data, sha256_hash_value, crypto::SHA256_LENGTH);
+ char sha256_hash_value[crypto::kSHA256Length];
+ crypto::SHA256HashString(data, sha256_hash_value, crypto::kSHA256Length);
std::string hash_in_hex = base::HexEncode(sha256_hash_value,
- crypto::SHA256_LENGTH);
+ crypto::kSHA256Length);
if (current_extension_fetch_.package_hash != hash_in_hex) {
NOTREACHED() << "Fetched blacklist checksum is not as expected. "

Powered by Google App Engine
This is Rietveld 408576698