Convert SHA256_LENGTH from a constant-in-anonymous-enum to a static const. This defines the cons...

chrome/browser/extensions/convert_web_app.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/convert_web_app.h"
 
 #include <cmath>
 #include <limits>
 #include <string>
 #include <vector>
@@ skipping 28 matching lines @@
 
 // Create the public key for the converted web app.
 //
 // Web apps are not signed, but the public key for an extension doubles as
 // its unique identity, and we need one of those. A web app's unique identity
 // is its manifest URL, so we hash that to create a public key. There will be
 // no corresponding private key, which means that these extensions cannot be
 // auto-updated using ExtensionUpdater. But Chrome does notice updates to the
 // manifest and regenerates these extensions.
 std::string GenerateKey(const GURL& manifest_url) {
-  char raw[crypto::SHA256_LENGTH] = {0};
+  char raw[crypto::kSHA256Length] = {0};
   std::string key;
-  crypto::SHA256HashString(manifest_url.spec().c_str(),
-                           raw,
-                           crypto::SHA256_LENGTH);
-  base::Base64Encode(std::string(raw, crypto::SHA256_LENGTH), &key);
+  crypto::SHA256HashString(manifest_url.spec().c_str(), raw,
+                           crypto::kSHA256Length);

[wtc, 2011/09/02 17:08:42]

Nit: since 'raw' and crypto::kSHA256Length are related (buffer
and buffer length), it looks nicer to have them on the same
line.  Up to you.

+  base::Base64Encode(std::string(raw, crypto::kSHA256Length), &key);
   return key;
 }
 
 }
 
 
 // Generates a version for the converted app using the current date. This isn't
 // really needed, but it seems like useful information.
 std::string ConvertTimeToExtensionVersion(const Time& create_time) {
   Time::Exploded create_time_exploded;
@@ skipping 119 matching lines @@
       extension_flags,
       &error);
   if (!extension) {
     LOG(ERROR) << error;
     return NULL;
   }
 
   temp_dir.Take();  // The caller takes ownership of the directory.
   return extension;
 }