Add link URL and success/failure callback parameters to chrome.webstore.install()

Add link URL and success/failure callback parameters to chrome.webstore.install()

The link URL is used to select between multiple <link rel="chrome-webstore-item">
elements on the page.

To keep track of callbacks, an install ID is generated at the start of each
chrome.webstore.install() call, so that the browser knows which ones to invoke
when an install completes.

Also adds validation of install requesting URL against the item's verified
domain (wasn't done until now since it wasn't testable).

R=aa@chromium.org
BUG=93380
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99889

[Aaron Boodman, 2011-09-06 23:24:32]

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
File chrome/renderer/extensions/chrome_webstore_bindings.cc (right):

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_webstore_bindings.cc:56: CallbackMap
success_callbacks;
Consider making a PendingWebstoreInstall class that contains the success and
failure functions. You could do the MakeWeak() thing in the constructor, so it's
a little more self-documenting. The argument to MakeWeak() could just the class
itself.

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_webstore_bindings.cc:57: CallbackMap
failure_callbacks;
Static non-pod variables are not allowed in Chromium. Use base::LazyInstance
instead. ExtensionBindingsContext has an example of this.

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_webstore_bindings.cc:285:
function->Call(v8::Object::New(), arraysize(argv), argv);
You can remove the function from the map after this call.

[Mihai Parparita -not on Chrome, 2011-09-07 00:05:03]

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
File chrome/renderer/extensions/chrome_webstore_bindings.cc (right):

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_webstore_bindings.cc:56: CallbackMap
success_callbacks;
On 2011/09/06 23:24:32, Aaron Boodman wrote:
> Consider making a PendingWebstoreInstall class that contains the success and
> failure functions. You could do the MakeWeak() thing in the constructor, so
it's
> a little more self-documenting. The argument to MakeWeak() could just the
class
> itself.

As discussed, this isn't that straightforward since we're dealing with two
distinct v8 objects that could be GC-ed at different times, so they can't use
the same PendingWebstoreInstall class.

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_webstore_bindings.cc:57: CallbackMap
failure_callbacks;
On 2011/09/06 23:24:32, Aaron Boodman wrote:
> Static non-pod variables are not allowed in Chromium. Use base::LazyInstance
> instead. ExtensionBindingsContext has an example of this.

Done.

http://codereview.chromium.org/7795032/diff/1/chrome/renderer/extensions/chro...
chrome/renderer/extensions/chrome_webstore_bindings.cc:285:
function->Call(v8::Object::New(), arraysize(argv), argv);
On 2011/09/06 23:24:32, Aaron Boodman wrote:
> You can remove the function from the map after this call.

Done.

[Aaron Boodman, 2011-09-07 00:07:36]

lgtm