Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: chrome/renderer/extensions/extension_render_view_helper.cc

Issue 7795032: Add link URL and success/failure callback parameters to chrome.webstore.install() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_render_view_helper.cc
diff --git a/chrome/renderer/extensions/extension_render_view_helper.cc b/chrome/renderer/extensions/extension_render_view_helper.cc
index b99432179a5a980e8d76b61ff446f9b50ba0f29c..8654b7d70b9b85db75bd90cc73310475a9b1afcf 100644
--- a/chrome/renderer/extensions/extension_render_view_helper.cc
+++ b/chrome/renderer/extensions/extension_render_view_helper.cc
@@ -12,6 +12,7 @@
#include "chrome/common/extensions/extension_messages.h"
#include "chrome/common/render_messages.h"
#include "chrome/common/url_constants.h"
+#include "chrome/renderer/extensions/chrome_webstore_bindings.h"
#include "chrome/renderer/extensions/event_bindings.h"
#include "chrome/renderer/extensions/extension_bindings_context.h"
#include "chrome/renderer/extensions/extension_process_bindings.h"
@@ -107,21 +108,16 @@ bool ExtensionRenderViewHelper::InstallWebApplicationUsingDefinitionFile(
}
void ExtensionRenderViewHelper::InlineWebstoreInstall(
- std::string webstore_item_id) {
+ int install_id, std::string webstore_item_id, GURL requestor_url) {
Send(new ExtensionHostMsg_InlineWebstoreInstall(
- routing_id(), webstore_item_id));
+ routing_id(), install_id, webstore_item_id, requestor_url));
}
void ExtensionRenderViewHelper::OnInlineWebstoreInstallResponse(
+ int install_id,
bool success,
const std::string& error) {
- // TODO(mihaip): dispatch these as events to the the WebFrame that initiated
- // the inline install.
- if (success) {
- VLOG(1) << "Inline install succeeded.";
- } else {
- VLOG(1) << "Inline install failed: " << error;
- }
+ ChromeWebstoreExtension::HandleInstallResponse(install_id, success, error);
}
bool ExtensionRenderViewHelper::OnMessageReceived(const IPC::Message& message) {
« no previous file with comments | « chrome/renderer/extensions/extension_render_view_helper.h ('k') | chrome/renderer/extensions/extension_renderer_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698