chrome/test/data/extensions/api_test/webstore_inline_install/install.html - Issue 7795032: Add link URL and success/failure callback parameters to chrome.webstore.install()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webstore_inline_install/install.html

Issue 7795032: Add link URL and success/failure callback parameters to chrome.webstore.install() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/webstore_inline_install/inlineinstall/detail/ecglahbcnmdpdciemllbhojghbkagdje ('k') | chrome/test/data/extensions/api_test/webstore_inline_install/install-non-verified-domain.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webstore_inline_install/install.html

diff --git a/chrome/test/data/extensions/api_test/webstore_inline_install/install.html b/chrome/test/data/extensions/api_test/webstore_inline_install/install.html

index 73121f222f8c0b2e130951fb9cc575e9765ca077..de32da4c07b9197a589381c9be95d24166001369 100644

--- a/chrome/test/data/extensions/api_test/webstore_inline_install/install.html

+++ b/chrome/test/data/extensions/api_test/webstore_inline_install/install.html

@@ -12,12 +12,19 @@

galleryUrl + '/detail/ecglahbcnmdpdciemllbhojghbkagdje';

try {

- chrome.webstore.install();

+ chrome.webstore.install(

+ undefined,

+ function() {

+ window.domAutomationController.send(true);

+ },

+ function(error) {

+ console.log('Unexpected error: ' + error);

+ window.domAutomationController.send(false);

+ });

} catch (e) {

window.domAutomationController.send(false);

throw e;

}

- window.domAutomationController.send(true);

}

</script>