Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: chrome/browser/extensions/extension_tab_helper.cc

Issue 7795032: Add link URL and success/failure callback parameters to chrome.webstore.install() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_tab_helper.cc
diff --git a/chrome/browser/extensions/extension_tab_helper.cc b/chrome/browser/extensions/extension_tab_helper.cc
index 6a2a391c7b15a3a9fcfe1e59a57d58aa5ce968a3..81615c481e6ad9a2867a2afd2e5d8533fae1e8a0 100644
--- a/chrome/browser/extensions/extension_tab_helper.cc
+++ b/chrome/browser/extensions/extension_tab_helper.cc
@@ -149,14 +149,16 @@ void ExtensionTabHelper::OnInstallApplication(const WebApplicationInfo& info) {
}
void ExtensionTabHelper::OnInlineWebstoreInstall(
- const std::string& webstore_item_id) {
+ int install_id,
+ const std::string& webstore_item_id,
+ const GURL& requestor_url) {
if (!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableInlineWebstoreInstall)) {
return;
}
scoped_refptr<WebstoreInlineInstaller> installer(new WebstoreInlineInstaller(
- tab_contents(), webstore_item_id, this));
+ tab_contents(), install_id, webstore_item_id, requestor_url, this));
installer->BeginInstall();
}
@@ -208,13 +210,15 @@ Browser* ExtensionTabHelper::GetBrowser() {
return NULL;
}
-void ExtensionTabHelper::OnInlineInstallSuccess() {
- Send(new ExtensionMsg_InlineWebstoreInstallResponse(routing_id(), true, ""));
+void ExtensionTabHelper::OnInlineInstallSuccess(int install_id) {
+ Send(new ExtensionMsg_InlineWebstoreInstallResponse(
+ routing_id(), install_id, true, ""));
}
-void ExtensionTabHelper::OnInlineInstallFailure(const std::string& error) {
+void ExtensionTabHelper::OnInlineInstallFailure(int install_id,
+ const std::string& error) {
Send(new ExtensionMsg_InlineWebstoreInstallResponse(
- routing_id(), false, error));
+ routing_id(), install_id, false, error));
}
TabContents* ExtensionTabHelper::GetAssociatedTabContents() const {
« no previous file with comments | « chrome/browser/extensions/extension_tab_helper.h ('k') | chrome/browser/extensions/webstore_inline_install_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698