chrome/common/extensions/extension_messages.h - Issue 7795032: Add link URL and success/failure callback parameters to chrome.webstore.install()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_messages.h

Issue 7795032: Add link URL and success/failure callback parameters to chrome.webstore.install() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review feedback Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | chrome/renderer/extensions/chrome_webstore_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/extension_messages.h

diff --git a/chrome/common/extensions/extension_messages.h b/chrome/common/extensions/extension_messages.h

index f09841a7b6e456a3e6d4fb42724d08ba1257b618..32dbd91499d16f0afc26544bd21687b3d2099b01 100644

--- a/chrome/common/extensions/extension_messages.h

+++ b/chrome/common/extensions/extension_messages.h

@@ -315,10 +315,13 @@ IPC_MESSAGE_ROUTED1(ExtensionHostMsg_InstallApplication,

WebApplicationInfo)

// Sent by the renderer to implement chrome.webstore.install().

-IPC_MESSAGE_ROUTED1(ExtensionHostMsg_InlineWebstoreInstall,

- std::string /* Web Store item ID */)

+IPC_MESSAGE_ROUTED3(ExtensionHostMsg_InlineWebstoreInstall,

+ int32 /* install id */,

+ std::string /* Web Store item ID */,

+ GURL /* requestor URL */)

// Send to renderer once the installation mentioned above is complete.

-IPC_MESSAGE_ROUTED2(ExtensionMsg_InlineWebstoreInstallResponse,

+IPC_MESSAGE_ROUTED3(ExtensionMsg_InlineWebstoreInstallResponse,

+ int32 /* install id */,

bool /* whether the install was successful */,

std::string /* error */)

« no previous file with comments | « chrome/browser/extensions/webstore_inline_installer.cc ('k') | chrome/renderer/extensions/chrome_webstore_bindings.h » ('j') | no next file with comments »