Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 7787028: Use the BitField class for Code::Flags. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Use the BitField class for Code::Flags. Use the BitField helper class for the code flags, so that we do not have to define both a shift and a mask explicitly. This makes changing the flags layout simpler. Also, make the 'mask' and 'max' members of BitField into constants, because they are constant and so that they can be used as constant expressions. E.g., so they can be used in declaring other const members or in static asserts. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -100 lines) Patch
M src/arm/ic-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/lithium.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/mips/ic-mips.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +15 lines, -19 lines 0 comments Download
M src/objects-inl.h View 5 chunks +17 lines, -33 lines 0 comments Download
M src/safepoint-table.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/utils.h View 2 chunks +11 lines, -15 lines 0 comments Download
M src/x64/ic-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 3 months ago (2011-09-09 13:24:43 UTC) #1
fschneider
9 years, 3 months ago (2011-09-12 09:15:30 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698