Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: src/stub-cache.cc

Issue 7787028: Use the BitField class for Code::Flags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/stub-cache.h ('k') | src/utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 // Validate that the name does not move on scavenge, and that we 67 // Validate that the name does not move on scavenge, and that we
68 // can use identity checks instead of string equality checks. 68 // can use identity checks instead of string equality checks.
69 ASSERT(!heap()->InNewSpace(name)); 69 ASSERT(!heap()->InNewSpace(name));
70 ASSERT(name->IsSymbol()); 70 ASSERT(name->IsSymbol());
71 71
72 // The state bits are not important to the hash function because 72 // The state bits are not important to the hash function because
73 // the stub cache only contains monomorphic stubs. Make sure that 73 // the stub cache only contains monomorphic stubs. Make sure that
74 // the bits are the least significant so they will be the ones 74 // the bits are the least significant so they will be the ones
75 // masked out. 75 // masked out.
76 ASSERT(Code::ExtractICStateFromFlags(flags) == MONOMORPHIC); 76 ASSERT(Code::ExtractICStateFromFlags(flags) == MONOMORPHIC);
77 ASSERT(Code::kFlagsICStateShift == 0); 77 STATIC_ASSERT((Code::ICStateField::kMask & 1) == 1);
78 78
79 // Make sure that the code type is not included in the hash. 79 // Make sure that the code type is not included in the hash.
80 ASSERT(Code::ExtractTypeFromFlags(flags) == 0); 80 ASSERT(Code::ExtractTypeFromFlags(flags) == 0);
81 81
82 // Compute the primary entry. 82 // Compute the primary entry.
83 int primary_offset = PrimaryOffset(name, flags, map); 83 int primary_offset = PrimaryOffset(name, flags, map);
84 Entry* primary = entry(primary_, primary_offset); 84 Entry* primary = entry(primary_, primary_offset);
85 Code* hit = primary->value; 85 Code* hit = primary->value;
86 86
87 // If the primary entry has useful data in it, we retire it to the 87 // If the primary entry has useful data in it, we retire it to the
(...skipping 1798 matching lines...) Expand 10 before | Expand all | Expand 10 after
1886 expected_receiver_type_ = 1886 expected_receiver_type_ =
1887 FunctionTemplateInfo::cast(signature->receiver()); 1887 FunctionTemplateInfo::cast(signature->receiver());
1888 } 1888 }
1889 } 1889 }
1890 1890
1891 is_simple_api_call_ = true; 1891 is_simple_api_call_ = true;
1892 } 1892 }
1893 1893
1894 1894
1895 } } // namespace v8::internal 1895 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/stub-cache.h ('k') | src/utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698