Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: src/arm/macro-assembler-arm.cc

Issue 7787028: Use the BitField class for Code::Flags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/compiler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1403 matching lines...) Expand 10 before | Expand all | Expand 10 after
1414 b(ne, miss); 1414 b(ne, miss);
1415 } 1415 }
1416 } 1416 }
1417 1417
1418 bind(&done); 1418 bind(&done);
1419 // Check that the value is a normal property. 1419 // Check that the value is a normal property.
1420 // t2: elements + (index * kPointerSize) 1420 // t2: elements + (index * kPointerSize)
1421 const int kDetailsOffset = 1421 const int kDetailsOffset =
1422 NumberDictionary::kElementsStartOffset + 2 * kPointerSize; 1422 NumberDictionary::kElementsStartOffset + 2 * kPointerSize;
1423 ldr(t1, FieldMemOperand(t2, kDetailsOffset)); 1423 ldr(t1, FieldMemOperand(t2, kDetailsOffset));
1424 tst(t1, Operand(Smi::FromInt(PropertyDetails::TypeField::mask()))); 1424 tst(t1, Operand(Smi::FromInt(PropertyDetails::TypeField::kMask)));
1425 b(ne, miss); 1425 b(ne, miss);
1426 1426
1427 // Get the value at the masked, scaled index and return. 1427 // Get the value at the masked, scaled index and return.
1428 const int kValueOffset = 1428 const int kValueOffset =
1429 NumberDictionary::kElementsStartOffset + kPointerSize; 1429 NumberDictionary::kElementsStartOffset + kPointerSize;
1430 ldr(result, FieldMemOperand(t2, kValueOffset)); 1430 ldr(result, FieldMemOperand(t2, kValueOffset));
1431 } 1431 }
1432 1432
1433 1433
1434 void MacroAssembler::AllocateInNewSpace(int object_size, 1434 void MacroAssembler::AllocateInNewSpace(int object_size,
(...skipping 1834 matching lines...) Expand 10 before | Expand all | Expand 10 after
3269 void CodePatcher::EmitCondition(Condition cond) { 3269 void CodePatcher::EmitCondition(Condition cond) {
3270 Instr instr = Assembler::instr_at(masm_.pc_); 3270 Instr instr = Assembler::instr_at(masm_.pc_);
3271 instr = (instr & ~kCondMask) | cond; 3271 instr = (instr & ~kCondMask) | cond;
3272 masm_.emit(instr); 3272 masm_.emit(instr);
3273 } 3273 }
3274 3274
3275 3275
3276 } } // namespace v8::internal 3276 } } // namespace v8::internal
3277 3277
3278 #endif // V8_TARGET_ARCH_ARM 3278 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/ic-arm.cc ('k') | src/compiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698