Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/x64/macro-assembler-x64.cc

Issue 7787028: Use the BitField class for Code::Flags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/ic-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3285 matching lines...) Expand 10 before | Expand all | Expand 10 after
3296 j(not_equal, miss); 3296 j(not_equal, miss);
3297 } 3297 }
3298 } 3298 }
3299 3299
3300 bind(&done); 3300 bind(&done);
3301 // Check that the value is a normal propety. 3301 // Check that the value is a normal propety.
3302 const int kDetailsOffset = 3302 const int kDetailsOffset =
3303 NumberDictionary::kElementsStartOffset + 2 * kPointerSize; 3303 NumberDictionary::kElementsStartOffset + 2 * kPointerSize;
3304 ASSERT_EQ(NORMAL, 0); 3304 ASSERT_EQ(NORMAL, 0);
3305 Test(FieldOperand(elements, r2, times_pointer_size, kDetailsOffset), 3305 Test(FieldOperand(elements, r2, times_pointer_size, kDetailsOffset),
3306 Smi::FromInt(PropertyDetails::TypeField::mask())); 3306 Smi::FromInt(PropertyDetails::TypeField::kMask));
3307 j(not_zero, miss); 3307 j(not_zero, miss);
3308 3308
3309 // Get the value at the masked, scaled index. 3309 // Get the value at the masked, scaled index.
3310 const int kValueOffset = 3310 const int kValueOffset =
3311 NumberDictionary::kElementsStartOffset + kPointerSize; 3311 NumberDictionary::kElementsStartOffset + kPointerSize;
3312 movq(result, FieldOperand(elements, r2, times_pointer_size, kValueOffset)); 3312 movq(result, FieldOperand(elements, r2, times_pointer_size, kValueOffset));
3313 } 3313 }
3314 3314
3315 3315
3316 void MacroAssembler::LoadAllocationTopHelper(Register result, 3316 void MacroAssembler::LoadAllocationTopHelper(Register result,
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
3888 CPU::FlushICache(address_, size_); 3888 CPU::FlushICache(address_, size_);
3889 3889
3890 // Check that the code was patched as expected. 3890 // Check that the code was patched as expected.
3891 ASSERT(masm_.pc_ == address_ + size_); 3891 ASSERT(masm_.pc_ == address_ + size_);
3892 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 3892 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
3893 } 3893 }
3894 3894
3895 } } // namespace v8::internal 3895 } } // namespace v8::internal
3896 3896
3897 #endif // V8_TARGET_ARCH_X64 3897 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/ic-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698