Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 7787028: Use the BitField class for Code::Flags. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/lithium.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 822 matching lines...) Expand 10 before | Expand all | Expand 10 after
833 j(not_equal, miss); 833 j(not_equal, miss);
834 } 834 }
835 } 835 }
836 836
837 bind(&done); 837 bind(&done);
838 // Check that the value is a normal propety. 838 // Check that the value is a normal propety.
839 const int kDetailsOffset = 839 const int kDetailsOffset =
840 NumberDictionary::kElementsStartOffset + 2 * kPointerSize; 840 NumberDictionary::kElementsStartOffset + 2 * kPointerSize;
841 ASSERT_EQ(NORMAL, 0); 841 ASSERT_EQ(NORMAL, 0);
842 test(FieldOperand(elements, r2, times_pointer_size, kDetailsOffset), 842 test(FieldOperand(elements, r2, times_pointer_size, kDetailsOffset),
843 Immediate(PropertyDetails::TypeField::mask() << kSmiTagSize)); 843 Immediate(PropertyDetails::TypeField::kMask << kSmiTagSize));
844 j(not_zero, miss); 844 j(not_zero, miss);
845 845
846 // Get the value at the masked, scaled index. 846 // Get the value at the masked, scaled index.
847 const int kValueOffset = 847 const int kValueOffset =
848 NumberDictionary::kElementsStartOffset + kPointerSize; 848 NumberDictionary::kElementsStartOffset + kPointerSize;
849 mov(result, FieldOperand(elements, r2, times_pointer_size, kValueOffset)); 849 mov(result, FieldOperand(elements, r2, times_pointer_size, kValueOffset));
850 } 850 }
851 851
852 852
853 void MacroAssembler::LoadAllocationTopHelper(Register result, 853 void MacroAssembler::LoadAllocationTopHelper(Register result,
(...skipping 1430 matching lines...) Expand 10 before | Expand all | Expand 10 after
2284 2284
2285 // Check that the code was patched as expected. 2285 // Check that the code was patched as expected.
2286 ASSERT(masm_.pc_ == address_ + size_); 2286 ASSERT(masm_.pc_ == address_ + size_);
2287 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap); 2287 ASSERT(masm_.reloc_info_writer.pos() == address_ + size_ + Assembler::kGap);
2288 } 2288 }
2289 2289
2290 2290
2291 } } // namespace v8::internal 2291 } } // namespace v8::internal
2292 2292
2293 #endif // V8_TARGET_ARCH_IA32 2293 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/ic-ia32.cc ('k') | src/lithium.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698