Issue 7766007: Only put the chrome frame resources in the locale dlls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7766007: Only put the chrome frame resources in the locale dlls. (Closed)

Created:
9 years, 3 months ago by tony

Modified:
9 years, 3 months ago

Reviewers:
ananta

CC:
chromium-reviews, amit, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Only put the chrome frame resources in the locale dlls. Chrome Frame needs 2 dialogs and an icon in the locale dlls. The rest of the strings and resources can be pulled from the locale pak files. This also removes the icon from the pak files and moves them into the dlls. BUG=94362 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98513

Patch Set 1 #

Patch Set 2 : remove include #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -398 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome_frame/chrome_frame.gyp	View		9 chunks	+15 lines, -3 lines	0 comments	Download
M	chrome_frame/find_dialog.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/locales/locales.gyp	View		3 chunks	+55 lines, -384 lines	0 comments	Download
M	chrome_frame/ready_mode/internal/ready_prompt_window.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome_frame/ready_mode/internal/ready_prompt_window.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome_frame/resources/chrome_frame_dialogs.grd	View		1 chunk	+134 lines, -0 lines	0 comments	Download
M	tools/grit/resource_ids	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

I'm not exactly sure how to test this. I'll run it through the trybots after ...

9 years, 3 months ago (2011-08-26 21:59:28 UTC) #1

LGTM

Expand Messages | Collapse Messages