Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 7714028: Switch to using .pak files for locale data on Windows. (Closed)

Created:
9 years, 4 months ago by tony
Modified:
9 years, 4 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, amit, pam+watch_chromium.org, jshin+watch_chromium.org, dhollowa
Visibility:
Public.

Description

Switch to using .pak files for locale data on Windows. We were using .dlls, but the .pak files are smaller and this will allow us to share more code across platforms. - Remove app/locales.gyp (used on win to generate the locale dlls) and references to it in other gyp(i) files. - Update various packaging scripts. - Move functions from resource_bundle_posix.cc to resource_bundle.cc (LoadResourcesDataPak, UnloadLocaleResources, GetLocalizedString, LoadLocaleResources) and delete the corresponding functions from resource_bundle_win.cc. Fixes from previous patch: - Made dependencies of packed_resources explicit (MSVS can't figure it out from the inputs). - Removed a couple cases where we were looking for dlls on Windows (in l10n_util.cc and l10n_util_unittest.cc). BUG=92724 TBR=cpu Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98103

Patch Set 1 #

Patch Set 2 : fix L10nUtilTest.GetAppLocale #

Patch Set 3 : compile #

Patch Set 4 : fix test dependencies #

Patch Set 5 : deps #

Patch Set 6 : more deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -969 lines) Patch
M build/all.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/app/locales/locales.gyp View 1 chunk +0 lines, -678 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
M chrome/chrome_exe.gypi View 1 2 3 4 3 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 chunks +2 lines, -6 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +1 line, -1 line 0 comments Download
M chrome/tools/build/win/FILES View 1 chunk +49 lines, -49 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +49 lines, -49 lines 0 comments Download
M chrome_frame/chrome_frame.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 2 2 chunks +2 lines, -7 lines 0 comments Download
M ui/base/resource/resource_bundle.h View 2 chunks +7 lines, -1 line 0 comments Download
M ui/base/resource/resource_bundle.cc View 4 chunks +86 lines, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_dummy.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/resource/resource_bundle_linux.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/base/resource/resource_bundle_posix.cc View 4 chunks +1 line, -68 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 4 chunks +13 lines, -80 lines 0 comments Download
M views/views.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
tony
Some small build fixes. Should pass for incremental builds and clobber builds.
9 years, 4 months ago (2011-08-24 19:43:15 UTC) #1
tony
9 years, 4 months ago (2011-08-24 20:22:29 UTC) #2
I'm going to TBR this change because I want to watch it in the tree for a few
hours.

Powered by Google App Engine
This is Rietveld 408576698