Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Unified Diff: ui/base/l10n/l10n_util_unittest.cc

Issue 7714028: Switch to using .pak files for locale data on Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more deps Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/l10n/l10n_util.cc ('k') | ui/base/resource/resource_bundle.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/l10n/l10n_util_unittest.cc
diff --git a/ui/base/l10n/l10n_util_unittest.cc b/ui/base/l10n/l10n_util_unittest.cc
index 778476c72e88dee5d5f82ea5f89cd08a33a9cc51..8ab08d5998908643cdaf7fc26f5d628bc6335539 100644
--- a/ui/base/l10n/l10n_util_unittest.cc
+++ b/ui/base/l10n/l10n_util_unittest.cc
@@ -90,7 +90,7 @@ void SetDefaultLocaleForTest(const std::string& tag, base::Environment* env) {
TEST_F(L10nUtilTest, GetAppLocale) {
scoped_ptr<base::Environment> env;
// Use a temporary locale dir so we don't have to actually build the locale
- // dlls for this test.
+ // pak files for this test.
FilePath orig_locale_dir;
PathService::Get(ui::DIR_LOCALES, &orig_locale_dir);
FilePath new_locale_dir;
@@ -115,14 +115,9 @@ TEST_F(L10nUtilTest, GetAppLocale) {
"ca@valencia",
};
-#if defined(OS_WIN)
- static const char kLocaleFileExtension[] = ".dll";
-#elif defined(OS_POSIX)
- static const char kLocaleFileExtension[] = ".pak";
-#endif
for (size_t i = 0; i < arraysize(filenames); ++i) {
FilePath filename = new_locale_dir.AppendASCII(
- filenames[i] + kLocaleFileExtension);
+ filenames[i] + ".pak");
file_util::WriteFile(filename, "", 0);
}
« no previous file with comments | « ui/base/l10n/l10n_util.cc ('k') | ui/base/resource/resource_bundle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698