Clean up users of a deprecated base::LaunchApp API.

Clean up users of a deprecated base::LaunchApp API. 

BUG=88990
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=92598

[Evan Martin, 2011-07-14 18:04:31]

This is the last cross-platform LaunchApp().  (There are a few more in a
Windows-specific ifdef.)

Now that I'm this far into the project, I see a few common patterns.  One is
using default launch options.  The other is that ~50% of callers want the
process handle.  I think I'm gonna switch the API after this to take the process
handle as a top-level argument.

That will allow the majority of calls to look like:
  base::LaunchProcess(cmdline, base::LaunchOptions(), NULL)
  base::LaunchProcess(cmdline, base::LaunchOptions(), &handle)

I can do all of that in one huge pass after this one.

[Mark Mentovai, 2011-07-14 18:12:15]

Win trybot failure. Looks like you need one more thing in
chrome_frame/ready_mode/internal/registry_ready_mode_state.cc.

[Evan Martin, 2011-07-14 18:16:12]

On 2011/07/14 18:12:15, Mark Mentovai wrote:
> Win trybot failure. Looks like you need one more thing in
> chrome_frame/ready_mode/internal/registry_ready_mode_state.cc.

Damn, I thought I had found the last.  Win trybot only emits one error per run
so the process is pretty slow...

[Mark Mentovai, 2011-07-14 18:17:22]

LGTM once you get the trybot green.

http://codereview.chromium.org/7351003/diff/5001/media/audio/win/audio_manage...
File media/audio/win/audio_manager_win.cc (right):

http://codereview.chromium.org/7351003/diff/5001/media/audio/win/audio_manage...
media/audio/win/audio_manager_win.cc:254: base::LaunchProcess(command_line,
options);
Seeing this pattern repeatedly makes me wonder if the interface should have
accepted a NULL-tolerant LaunchOptions*.

[Evan Martin, 2011-07-14 18:20:32]

On 2011/07/14 18:17:22, Mark Mentovai wrote:
> LGTM once you get the trybot green.
> 
>
http://codereview.chromium.org/7351003/diff/5001/media/audio/win/audio_manage...
> File media/audio/win/audio_manager_win.cc (right):
> 
>
http://codereview.chromium.org/7351003/diff/5001/media/audio/win/audio_manage...
> media/audio/win/audio_manager_win.cc:254: base::LaunchProcess(command_line,
> options);
> Seeing this pattern repeatedly makes me wonder if the interface should have
> accepted a NULL-tolerant LaunchOptions*.

Hm, good point.  I will email about it separately.