Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3189)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_test.cc

Issue 7351003: Clean up users of a deprecated base::LaunchApp API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win-only Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/process_singleton_uitest.cc ('k') | chrome/browser/service/service_process_control.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_test.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_test.cc b/chrome/browser/safe_browsing/safe_browsing_test.cc
index 5a522083632b82190d8900f3d70f7cc9637483c1..998fcb1a4d4c85880681e1630f0001acab11f305 100644
--- a/chrome/browser/safe_browsing/safe_browsing_test.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_test.cc
@@ -145,7 +145,12 @@ class SafeBrowsingTestServer {
cmd_line.AppendArgNative(FILE_PATH_LITERAL("--datafile=") +
datafile.value());
- if (!base::LaunchApp(cmd_line, false, true, &server_handle_)) {
+ base::LaunchOptions options;
+#if defined(OS_WIN)
+ options.start_hidden = true;
+#endif
+ options.process_handle = &server_handle_;
+ if (!base::LaunchProcess(cmd_line, options)) {
LOG(ERROR) << "Failed to launch server: "
<< cmd_line.command_line_string();
return false;
« no previous file with comments | « chrome/browser/process_singleton_uitest.cc ('k') | chrome/browser/service/service_process_control.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698