chrome/service/service_child_process_host.cc - Issue 7351003: Clean up users of a deprecated base::LaunchApp API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/service_child_process_host.cc

Issue 7351003: Clean up users of a deprecated base::LaunchApp API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: win-only Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/service_child_process_host.cc

diff --git a/chrome/service/service_child_process_host.cc b/chrome/service/service_child_process_host.cc

index 3222a4833472f558fbb0bdabca0447ec7d64d1ec..b9e7886f8fd6b481c893a3be88449de51c3e4f51 100644

--- a/chrome/service/service_child_process_host.cc

+++ b/chrome/service/service_child_process_host.cc

@@ -36,7 +36,9 @@ bool ServiceChildProcessHost::Launch(CommandLine* cmd_line,

if (no_sandbox) {

base::ProcessHandle process = base::kNullProcessHandle;

cmd_line->AppendSwitch(switches::kNoSandbox);

- base::LaunchApp(*cmd_line, false, false, &process);

+ base::LaunchOptions options;

+ options.process_handle = &process;

+ base::LaunchProcess(*cmd_line, options);

set_handle(process);

} else {

set_handle(sandbox::StartProcessWithAccess(cmd_line, exposed_dir));