chrome/installer/util/product.cc - Issue 7351003: Clean up users of a deprecated base::LaunchApp API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/product.cc

Issue 7351003: Clean up users of a deprecated base::LaunchApp API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: win-only Created 9 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/util/product.cc

diff --git a/chrome/installer/util/product.cc b/chrome/installer/util/product.cc

index 7609d83680b818e9cda382c3723d8f46423a9f3d..6d3d44d39ba77ee50c3ef4eeba4b309cb2425a8a 100644

--- a/chrome/installer/util/product.cc

+++ b/chrome/installer/util/product.cc

@@ -62,7 +62,8 @@ bool Product::LaunchChrome(const FilePath& application_path) const {

bool success = !application_path.empty();

if (success) {

CommandLine cmd(application_path.Append(installer::kChromeExe));

- success = base::LaunchApp(cmd, false, false, NULL);

+ base::LaunchOptions options;

+ success = base::LaunchProcess(cmd, options);

}

return success;

}