Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4712)

Unified Diff: base/process_util.h

Issue 7351003: Clean up users of a deprecated base::LaunchApp API. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: win-only Created 9 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/process_util.h
diff --git a/base/process_util.h b/base/process_util.h
index 6820d426bedd470f567d4d55d0ab60ae4f7ad471..3d06f837ac19ed28d51ee9a9f5f7ec82e8078db2 100644
--- a/base/process_util.h
+++ b/base/process_util.h
@@ -358,9 +358,9 @@ BASE_API char** AlterEnvironment(const environment_vector& changes,
const char* const* const env);
#endif // defined(OS_POSIX)
-// Executes the application specified by cl. This function delegates to one
-// of the above platform-specific functions.
+#if defined(OS_WIN)
// TODO(evan): deprecated; change callers to use LaunchProcess, remove.
+// Successfully deprecated on non-Windows.
inline bool LaunchApp(const CommandLine& cl, bool wait, bool start_hidden,
ProcessHandle* process_handle) {
LaunchOptions options;
@@ -369,6 +369,7 @@ inline bool LaunchApp(const CommandLine& cl, bool wait, bool start_hidden,
return LaunchProcess(cl, options);
}
+#endif
// Executes the application specified by |cl| and wait for it to exit. Stores
// the output (stdout) in |output|. Redirects stderr to /dev/null. Returns true
« no previous file with comments | « no previous file | chrome/browser/browser_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698