Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 7304002: Correct reporting of compressed texture formats and shader binary formats (Closed)

Created:
9 years, 5 months ago by greggman
Modified:
9 years, 5 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Correct reporting of compressed texture formats and shader binary formats NOTE: There's an issue here that before this change the largest number of values returned by glGetXXX was 4 and now it's undefined. The issue will come up if there are ever more than 15 because the GLES2Implementation only currently handles 15. See GLES2Implementation::kMaxSizeOfSimpleResult. http://code.google.com/p/chromium/issues/detail?id=88227 TEST=unit tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=91781

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -19 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 chunks +6 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.h View 2 chunks +20 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_unittest.cc View 1 chunk +17 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 6 chunks +29 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation.h View 2 chunks +5 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_validation_implementation_autogen.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
apatrick_chromium
9 years, 5 months ago (2011-07-07 21:14:32 UTC) #1
LGTM

Powered by Google App Engine
This is Rietveld 408576698