Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 7158002: Revert 89002 - Enforce RGB even on buggy drivers. (Closed)

Created:
9 years, 6 months ago by asargent_no_longer_on_chrome
Modified:
9 years, 6 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 89002 - Enforce RGB even on buggy drivers. Also STENCIL and DEPTH. This might not be a complete solution. It assumes that if we ask for an RGB backbuffer or renderbuffer and the driver gives us RGBA that we can still clear that RGBA to 1,1,1,1. After that it sets the masks so that alpha can never be rendered to. Similarly for DEPTH and STENCILS. It's possible we should just always ask for RGBA, at least for Renderbuffers. TEST=unit tests, ran OpenGL ES 2.0 conformance test and WebGL conformance tests. BUG=85385 R=apatrick@chromium.org Review URL: http://codereview.chromium.org/7099007 TBR=gman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -839 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 7 chunks +6 lines, -27 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 2 chunks +1 line, -6 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 5 chunks +1 line, -33 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 8 chunks +1 line, -29 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 29 chunks +29 lines, -187 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 20 chunks +48 lines, -429 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 2 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 3 chunks +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 3 chunks +5 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 8 chunks +26 lines, -71 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 3 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
asargent_no_longer_on_chrome
9 years, 6 months ago (2011-06-14 16:47:38 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698