Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 7099007: Enforce RGB even on buggy drivers. (Closed)

Created:
9 years, 6 months ago by greggman
Modified:
9 years, 6 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Enforce RGB even on buggy drivers. Also STENCIL and DEPTH. This might not be a complete solution. It assumes that if we ask for an RGB backbuffer or renderbuffer and the driver gives us RGBA that we can still clear that RGBA to 1,1,1,1. After that it sets the masks so that alpha can never be rendered to. Similarly for DEPTH and STENCILS. It's possible we should just always ask for RGBA, at least for Renderbuffers. TEST=unit tests, ran OpenGL ES 2.0 conformance test and WebGL conformance tests. BUG=85385 R=apatrick@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89002

Patch Set 1 #

Patch Set 2 : fix cast warning #

Patch Set 3 : add checks for reading GL_ALPHA_BITS etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+839 lines, -125 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 7 chunks +27 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 2 chunks +6 lines, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 5 chunks +33 lines, -1 line 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 8 chunks +29 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 28 chunks +187 lines, -29 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 20 chunks +429 lines, -48 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 2 chunks +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 3 chunks +2 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 2 3 chunks +20 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 2 8 chunks +71 lines, -26 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
greggman
9 years, 6 months ago (2011-06-09 22:20:12 UTC) #1
apatrick_chromium
9 years, 6 months ago (2011-06-09 23:00:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698