Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 7115005: Reverse menu anchor position provided to views::MenuItemView for RTL languages. (Closed)

Created:
9 years, 6 months ago by rhashimoto
Modified:
9 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Reverse menu anchor position provided to views::MenuItemView for RTL languages. The GTK implementation of Menu2 reverses the menu alignment specified in RunMenuAt() if IsRTL() is true, i.e. TOPRIGHT becomes TOPLEFT and vice versa. This CL makes views::MenuItemView behave the same way. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88218

Patch Set 1 #

Patch Set 2 : Fix bookmark bar folder menus. #

Patch Set 3 : Remove whitespace change. #

Patch Set 4 : Fixed BrowserActionOverflowMenuController. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/wrench_menu.cc View 1 chunk +1 line, -2 lines 0 comments Download
M views/controls/menu/menu_controller.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M views/controls/menu/menu_item_view.h View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rhashimoto
9 years, 6 months ago (2011-06-07 00:51:24 UTC) #1
oshima
LGTM
9 years, 6 months ago (2011-06-07 01:10:43 UTC) #2
sky
What about the other places that use MenuItemView, like bookmark folders?
9 years, 6 months ago (2011-06-07 15:31:21 UTC) #3
rhashimoto
On 2011/06/07 15:31:21, sky wrote: > What about the other places that use MenuItemView, like ...
9 years, 6 months ago (2011-06-07 18:50:24 UTC) #4
sky
LGTM
9 years, 6 months ago (2011-06-07 20:06:10 UTC) #5
commit-bot: I haz the power
9 years, 6 months ago (2011-06-07 22:15:39 UTC) #6
Change committed as 88218

Powered by Google App Engine
This is Rietveld 408576698