chrome/browser/ui/views/wrench_menu.cc - Issue 7115005: Reverse menu anchor position provided to views::MenuItemView for RTL languages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/wrench_menu.cc

Issue 7115005: Reverse menu anchor position provided to views::MenuItemView for RTL languages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed BrowserActionOverflowMenuController. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc ('k') | views/controls/menu/menu_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/wrench_menu.cc

diff --git a/chrome/browser/ui/views/wrench_menu.cc b/chrome/browser/ui/views/wrench_menu.cc

index b1b69ceee53fea6d487ccf5ec9e5fad9ddbf3e4d..4a1068ffa4d17d759cb69aad046f80616e7fbce3 100644

--- a/chrome/browser/ui/views/wrench_menu.cc

+++ b/chrome/browser/ui/views/wrench_menu.cc

@@ -604,8 +604,7 @@ void WrenchMenu::RunMenu(views::MenuButton* host) {

gfx::Rect bounds(screen_loc, host->size());

UserMetrics::RecordAction(UserMetricsAction("ShowAppMenu"));

root_->RunMenuAt(host->GetWindow()->GetNativeWindow(), host, bounds,

- base::i18n::IsRTL() ? MenuItemView::TOPLEFT : MenuItemView::TOPRIGHT,

- true);

+ MenuItemView::TOPRIGHT, true);

if (bookmark_menu_delegate_.get()) {

BookmarkModel* model = browser_->profile()->GetBookmarkModel();

if (model)