Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 7115005: Reverse menu anchor position provided to views::MenuItemView for RTL languages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed BrowserActionOverflowMenuController. Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index 8ac480ec5293d737657d1a92ddbd163e505a8afa..233a61f39823ca556d66570a3d77260bac324661 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -528,14 +528,6 @@ void BookmarkBarView::GetAnchorPositionForButton(
*anchor = MenuItemView::TOPRIGHT;
else
*anchor = MenuItemView::TOPLEFT;
-
- // Invert orientation if right to left.
- if (base::i18n::IsRTL()) {
- if (*anchor == MenuItemView::TOPRIGHT)
- *anchor = MenuItemView::TOPLEFT;
- else
- *anchor = MenuItemView::TOPRIGHT;
- }
}
views::MenuItemView* BookmarkBarView::GetMenu() {
« no previous file with comments | « no previous file | chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698