chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc - Issue 7115005: Reverse menu anchor position provided to views::MenuItemView for RTL languages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 7115005: Reverse menu anchor position provided to views::MenuItemView for RTL languages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed BrowserActionOverflowMenuController. Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

index 45c5785c3b9dd683849a639f5e3381ab08d652f2..23f2f6bcf4cb35d1592218b256d8017c6d96bbc4 100644

--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

@@ -64,8 +64,7 @@ bool BrowserActionOverflowMenuController::RunMenu(gfx::NativeWindow window,

bounds.set_x(screen_loc.x());

bounds.set_y(screen_loc.y());

- views::MenuItemView::AnchorPosition anchor = base::i18n::IsRTL() ?

- views::MenuItemView::TOPLEFT : views::MenuItemView::TOPRIGHT;

+ views::MenuItemView::AnchorPosition anchor = views::MenuItemView::TOPRIGHT;

if (for_drop) {

menu_->RunMenuForDropAt(window, bounds, anchor);

} else {

« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('k') | chrome/browser/ui/views/wrench_menu.cc » ('j') | no next file with comments »