GLContext no longer holds a pointer to a GLSurface.

GLContext no longer holds a pointer to a GLSurface.

This is part of an ongoing effort to treat GL contexts and GL surfaces as independent entities.

TEST=run WebGL on mac, windows and linux, trybots
BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86332

[Alexey Marinichev, 2011-05-17 20:20:53]

http://codereview.chromium.org/7021014/diff/8001/ui/gfx/gl/gl_context_glx.cc
File ui/gfx/gl/gl_context_glx.cc (right):

http://codereview.chromium.org/7021014/diff/8001/ui/gfx/gl/gl_context_glx.cc#...
ui/gfx/gl/gl_context_glx.cc:47: static_cast<GLXFBConfig>(NULL /* TODO: fix */),
Nvidia driver segfaults on this.  No good!

[apatrick_chromium, 2011-05-18 21:48:00]

Ready for review. Thoroughly tested on mesa.

[amarinichev, 2011-05-19 00:03:04]

On 2011/05/18 21:48:00, apatrick_chromium wrote:
> Ready for review. Thoroughly tested on mesa.

Doesn't work with Nvidia driver either.  Getting this on any 3D content:

[16139:16139:73270651094:ERROR:gl_context_glx.cc(120)] Couldn't make context
current.
[16139:16139:73270651452:ERROR:x11_util.cc(862)] X Error detected: serial 83,
error_code 8 (BadMatch (invalid parameter attributes)), request_code 128,
minor_code 26 (X_GLXMakeContextCurrent)

I applied the patch to the two-days old tree, will try the most recent one now.

[apatrick_chromium, 2011-05-20 23:57:02]

I think this will fix it. I added a "compatible_surface" argument to
CreateGLContext and it creates a GLContext with the same FBConfig as that
surface.

[Alexey Marinichev, 2011-05-23 18:19:12]

http://codereview.chromium.org/7021014/diff/34001/ui/gfx/gl/gl_context.h
File ui/gfx/gl/gl_context.h (right):

http://codereview.chromium.org/7021014/diff/34001/ui/gfx/gl/gl_context.h#newc...
ui/gfx/gl/gl_context.h:26: GLSurface* compatible_surface) = 0;
compatible_surface is used only by linux and osmesa contexts, right?  Maybe it's
worth mentioning here?

Other than that, LGTM