Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well. (Closed)

Created:
9 years, 6 months ago by Nico

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, dhollowa, kkania, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Turn on -Wdelete-non-virtual-dtor for chromeos as well. All of the changes in this CL are to shut up the warning, not because of real problems (I fixed these in separate CLs). See the bug for a disussion of this change. BUG=84424 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88385

Patch Set 1 #

Patch Set 2 : rebase #

Created: 9 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -16 lines)			Patch
M	build/common.gypi	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider_views.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View		5 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/user_cros_settings_provider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/tooltip_window_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages