Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1089)

Unified Diff: chrome/browser/chromeos/cros/network_library.h

Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/cros/network_library.h
diff --git a/chrome/browser/chromeos/cros/network_library.h b/chrome/browser/chromeos/cros/network_library.h
index 6fdc7e66c60d4b3427203d9182b8b202da6b12c1..0e9f0d88a37f7e7087f371fbe0d2f9496ee28f30 100644
--- a/chrome/browser/chromeos/cros/network_library.h
+++ b/chrome/browser/chromeos/cros/network_library.h
@@ -883,6 +883,8 @@ class NetworkLibrary {
// Called when the state of the network manager has changed,
// for example, networks have appeared or disappeared.
virtual void OnNetworkManagerChanged(NetworkLibrary* obj) = 0;
+ protected:
+ ~NetworkManagerObserver() { }
};
class NetworkObserver {
@@ -891,6 +893,8 @@ class NetworkLibrary {
// for example signal strength or connection state.
virtual void OnNetworkChanged(NetworkLibrary* cros,
const Network* network) = 0;
+ protected:
+ ~NetworkObserver() {}
};
class NetworkDeviceObserver {
@@ -899,12 +903,16 @@ class NetworkLibrary {
// for example SIMLock state for cellular.
virtual void OnNetworkDeviceChanged(NetworkLibrary* cros,
const NetworkDevice* device) = 0;
+ protected:
+ ~NetworkDeviceObserver() {}
};
class CellularDataPlanObserver {
public:
// Called when the cellular data plan has changed.
virtual void OnCellularDataPlanChanged(NetworkLibrary* obj) = 0;
+ protected:
+ ~CellularDataPlanObserver() {}
};
class PinOperationObserver {
@@ -913,6 +921,8 @@ class NetworkLibrary {
// Network is NULL when we don't have an associated Network object.
virtual void OnPinOperationCompleted(NetworkLibrary* cros,
PinOperationError error) = 0;
+ protected:
+ ~PinOperationObserver() {}
};
class UserActionObserver {
@@ -921,6 +931,8 @@ class NetworkLibrary {
// Network is NULL when we don't have an associated Network object.
virtual void OnConnectionInitiated(NetworkLibrary* cros,
const Network* network) = 0;
+ protected:
+ ~UserActionObserver() {}
};
virtual ~NetworkLibrary() {}
« no previous file with comments | « chrome/browser/automation/testing_automation_provider_views.cc ('k') | chrome/browser/chromeos/login/login_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698