Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: chrome/browser/automation/testing_automation_provider_views.cc

Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/chromeos/cros/network_library.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider_views.cc
diff --git a/chrome/browser/automation/testing_automation_provider_views.cc b/chrome/browser/automation/testing_automation_provider_views.cc
index fd685b21e96170efed4323a141d10ef2e517b086..797f5ca44ae27b01bc38aebfbebf884fde3458e2 100644
--- a/chrome/browser/automation/testing_automation_provider_views.cc
+++ b/chrome/browser/automation/testing_automation_provider_views.cc
@@ -37,7 +37,7 @@ class ViewFocusChangeWaiter : public views::FocusChangeListener {
FocusWillChange(NULL, focus_manager_->GetFocusedView());
}
- ~ViewFocusChangeWaiter() {
+ virtual ~ViewFocusChangeWaiter() {
focus_manager_->RemoveFocusChangeListener(this);
}
@@ -87,6 +87,8 @@ class TestingAutomationProvider::PopupMenuWaiter : public views::MenuListener {
toolbar_view_->AddMenuListener(this);
}
+ virtual ~PopupMenuWaiter() {}
+
// Implementation of views::MenuListener
virtual void OnMenuOpened() {
toolbar_view_->RemoveMenuListener(this);
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/chromeos/cros/network_library.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698