chrome/browser/chromeos/user_cros_settings_provider.cc - Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/user_cros_settings_provider.cc

Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/user_cros_settings_provider.cc

diff --git a/chrome/browser/chromeos/user_cros_settings_provider.cc b/chrome/browser/chromeos/user_cros_settings_provider.cc

index f44cb43af9eadcad0ebcb646c8e01cf5d57cc7f3..d4303383b6d99ecedc28e1a49568451ee6615f96 100644

--- a/chrome/browser/chromeos/user_cros_settings_provider.cc

+++ b/chrome/browser/chromeos/user_cros_settings_provider.cc

@@ -258,7 +258,7 @@ class UserCrosSettingsTrust : public SignedSettingsHelper::Callback {

Reload();

}

- ~UserCrosSettingsTrust() {

+ virtual ~UserCrosSettingsTrust() {

if (BrowserThread::CurrentlyOn(BrowserThread::UI) &&

CrosLibrary::Get()->EnsureLoaded()) {

// Cancels all pending callbacks from us.

« no previous file with comments | « chrome/browser/chromeos/login/user_manager.cc ('k') | views/widget/tooltip_window_gtk.h » ('j') | no next file with comments »