build/common.gypi - Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 6995085: Turn on -Wdelete-non-virtual-dtor for chromeos as well. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 9 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index 06674f3f3533010552a1298b1bee769fa56ce15a..fd1466dab5b22dbbe3e31790e014beb3998d457b 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -1353,18 +1353,6 @@

}]],

}],

- ['clang==1 and chromeos==1', {

- 'target_conditions': [

- ['_toolset=="target"', {

- 'cflags': [

- # TODO(thakis): Remove this once all instances of this

- # are fixed in the views and chromeos code.

- # http://crbug.com/84424

- # TODO(thakis): Add back in when rolling clang past r131989

- '-Wno-delete-non-virtual-dtor',

- ],

- }]],

- }],

['clang==1 and clang_use_chrome_plugins==1', {

'target_conditions': [

['_toolset=="target"', {

« no previous file with comments | « no previous file | chrome/browser/automation/testing_automation_provider_views.cc » ('j') | no next file with comments »