Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 6969100: Hook up shader long variable name mapping with GPU command buffer port. (Closed)

Created:
9 years, 6 months ago by Zhenyao Mo
Modified:
9 years, 6 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Hook up shader long variable name mapping with GPU command buffer port. shader long variable name mapping is implemented in Angle shader translator. We should hook up the feature with GPU command buffer so long names won't cause shader compile/link failure or crashes. BUG=84753 TEST=tree green, webgl's conformance/glsl-conformance.html and conformance/glsl-long-variable-names pass on all platforms (Mac/Win/Linux), gles2 conformance test suites run ok. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87899

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -35 lines) Patch
M gpu/command_buffer/service/program_manager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 6 chunks +19 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/shader_manager_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.h View 1 chunk +4 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 4 chunks +12 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/shader_translator_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
Please review. Thanks.
9 years, 6 months ago (2011-06-03 21:56:24 UTC) #1
greggman
9 years, 6 months ago (2011-06-03 22:46:24 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698