Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 6900006: Tegra2: Add more clock support (Closed)

Created:
9 years, 8 months ago by sjg
Modified:
9 years, 7 months ago
Reviewers:
vb, Tom Warren, robotboy
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Tegra2: Add more clock support This adds functions to enable/disable clocks and reset to on-chip peripherals. BUG=chromium-os:13875 TEST=build U-Boot for Seaboard, boot Change-Id: I80fe1d0c0b7dd10aa58ce5bb1d9290b6664d5413 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=849880f

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fixed up comment style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -120 lines) Patch
M arch/arm/cpu/armv7/tegra2/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M arch/arm/cpu/armv7/tegra2/ap20.c View 6 chunks +19 lines, -38 lines 0 comments Download
A arch/arm/cpu/armv7/tegra2/clock.c View 1 1 chunk +163 lines, -0 lines 0 comments Download
M arch/arm/include/asm/arch-tegra2/clk_rst.h View 1 4 chunks +52 lines, -48 lines 0 comments Download
A arch/arm/include/asm/arch-tegra2/clock.h View 1 chunk +264 lines, -0 lines 0 comments Download
M board/nvidia/common/board.c View 4 chunks +19 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sjg
Here are some clock functions and cleaning up of the structures. This is desirable rather ...
9 years, 8 months ago (2011-04-21 23:45:54 UTC) #1
Tom Warren
Just some comments that need fixin'. Otherwise, LGTM. http://codereview.chromium.org/6900006/diff/1/arch/arm/cpu/armv7/tegra2/clock.c File arch/arm/cpu/armv7/tegra2/clock.c (right): http://codereview.chromium.org/6900006/diff/1/arch/arm/cpu/armv7/tegra2/clock.c#newcode88 arch/arm/cpu/armv7/tegra2/clock.c:88: // ...
9 years, 8 months ago (2011-04-26 18:15:32 UTC) #2
sjg
9 years, 8 months ago (2011-04-26 21:24:31 UTC) #3
http://codereview.chromium.org/6900006/diff/1/arch/arm/cpu/armv7/tegra2/clock.c
File arch/arm/cpu/armv7/tegra2/clock.c (right):

http://codereview.chromium.org/6900006/diff/1/arch/arm/cpu/armv7/tegra2/clock...
arch/arm/cpu/armv7/tegra2/clock.c:88: // calculate the stable time
On 2011/04/26 18:15:32, Tom Warren wrote:
> Needs to be a classic C comment (/* */) for upstream.

Done.

http://codereview.chromium.org/6900006/diff/1/arch/arm/cpu/armv7/tegra2/clock...
arch/arm/cpu/armv7/tegra2/clock.c:99: /* Enable clk to UART */
On 2011/04/26 18:15:32, Tom Warren wrote:
> S/B 'Enable clk to periph'? or 'device' or 'toy'

Done.

http://codereview.chromium.org/6900006/diff/1/arch/arm/cpu/armv7/tegra2/clock...
arch/arm/cpu/armv7/tegra2/clock.c:126: /* Enable clk to UART */
On 2011/04/26 18:15:32, Tom Warren wrote:
> Same as above, replace UART w/periph, device, etc. And it should be 'reset',
not
> 'clk'.

Done.

http://codereview.chromium.org/6900006/diff/1/arch/arm/include/asm/arch-tegra...
File arch/arm/include/asm/arch-tegra2/clk_rst.h (right):

http://codereview.chromium.org/6900006/diff/1/arch/arm/include/asm/arch-tegra...
arch/arm/include/asm/arch-tegra2/clk_rst.h:50: 
On 2011/04/26 18:15:32, Tom Warren wrote:
> I'd like to see the values (6, 3, 3) lined up w/tabs, as well as the comments.

Done.

http://codereview.chromium.org/6900006/diff/1/arch/arm/include/asm/arch-tegra...
arch/arm/include/asm/arch-tegra2/clk_rst.h:55: uint
crc_clk_out_enb[TEGRA_CLK_REGS]; /* _CLK_OUT_ENB_L/H/U_0 */
On 2011/04/26 18:15:32, Tom Warren wrote:
> Ditto. Line up comments.

Have done as best I can given line length limitations

Powered by Google App Engine
This is Rietveld 408576698