Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6883179: Rework FlushSync to return early if commands have been processed since the last update (Closed)

Created:
9 years, 8 months ago by piman
Modified:
9 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, polina, nfullagar
Visibility:
Public.

Description

Rework FlushSync to return early if commands have been processed since the last update BUG=80480 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=83442

Patch Set 1 #

Patch Set 2 : cleanup, fix tests #

Total comments: 3

Patch Set 3 : Fix compile error, restore lost context functionality #

Patch Set 4 : Bump PPB_Context3DTrusted version #

Patch Set 5 : remove stale pgl stuff #

Patch Set 6 : Fix win32-only instance #

Patch Set 7 : rebase #

Total comments: 2

Patch Set 8 : style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -1439 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.h View 1 2 3 4 5 6 4 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 1 2 3 4 5 6 7 6 chunks +25 lines, -15 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 3 4 5 6 1 chunk +2 lines, -5 lines 0 comments Download
M content/renderer/command_buffer_proxy.h View 3 chunks +1 line, -13 lines 0 comments Download
M content/renderer/command_buffer_proxy.cc View 1 3 chunks +27 lines, -52 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_demo.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/ring_buffer_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/command_buffer.h View 3 chunks +12 lines, -5 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.h View 1 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 2 chunks +12 lines, -13 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.cc View 1 4 chunks +16 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.h View 1 2 3 4 5 6 3 chunks +6 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 2 3 4 5 6 2 chunks +10 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_mock.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_unittest.cc View 1 11 chunks +15 lines, -15 lines 0 comments Download
D gpu/demos/framework/Plugin_Info.plist View 1 2 3 4 1 chunk +0 lines, -46 lines 0 comments Download
D gpu/demos/framework/plugin.h View 1 2 3 4 1 chunk +0 lines, -58 lines 0 comments Download
D gpu/demos/framework/plugin.cc View 1 2 3 4 1 chunk +0 lines, -209 lines 0 comments Download
D gpu/demos/framework/plugin.def View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
D gpu/demos/framework/plugin.rc View 1 2 3 4 1 chunk +0 lines, -35 lines 0 comments Download
M gpu/demos/framework/window.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 6 1 chunk +0 lines, -24 lines 0 comments Download
M gpu/ipc/gpu_command_buffer_traits.cc View 2 chunks +3 lines, -1 line 0 comments Download
D gpu/pgl/command_buffer_pepper.h View 1 2 3 4 1 chunk +0 lines, -59 lines 0 comments Download
D gpu/pgl/command_buffer_pepper.cc View 1 2 3 4 1 chunk +0 lines, -209 lines 0 comments Download
D gpu/pgl/pgl.h View 1 2 3 4 1 chunk +0 lines, -68 lines 0 comments Download
D gpu/pgl/pgl.cc View 1 2 3 4 1 chunk +0 lines, -253 lines 0 comments Download
D gpu/pgl/pgl_proc_address.cc View 1 2 3 4 1 chunk +0 lines, -315 lines 0 comments Download
M ppapi/c/dev/ppb_context_3d_trusted_dev.h View 1 2 3 4 5 6 3 chunks +14 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppb_context_3d_proxy.cc View 7 chunks +30 lines, -10 lines 0 comments Download
M webkit/plugins/ppapi/ppb_context_3d_impl.cc View 1 4 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
piman
http://codereview.chromium.org/6883179/diff/1001/ppapi/c/dev/ppb_context_3d_trusted_dev.h File ppapi/c/dev/ppb_context_3d_trusted_dev.h (right): http://codereview.chromium.org/6883179/diff/1001/ppapi/c/dev/ppb_context_3d_trusted_dev.h#newcode99 ppapi/c/dev/ppb_context_3d_trusted_dev.h:99: struct PP_Context3DTrustedState (*FlushSyncFast)(PP_Resource context, This was added instead of ...
9 years, 7 months ago (2011-04-27 21:28:39 UTC) #1
apatrick_chromium
http://codereview.chromium.org/6883179/diff/1001/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (left): http://codereview.chromium.org/6883179/diff/1001/content/common/gpu/gpu_command_buffer_stub.cc#oldcode321 content/common/gpu/gpu_command_buffer_stub.cc:321: channel_->LoseAllContexts(); Why did you remove this?
9 years, 7 months ago (2011-04-27 22:52:44 UTC) #2
piman
http://codereview.chromium.org/6883179/diff/1001/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (left): http://codereview.chromium.org/6883179/diff/1001/content/common/gpu/gpu_command_buffer_stub.cc#oldcode321 content/common/gpu/gpu_command_buffer_stub.cc:321: channel_->LoseAllContexts(); On 2011/04/27 22:52:44, apatrick_chromium wrote: > Why did ...
9 years, 7 months ago (2011-04-27 23:44:29 UTC) #3
apatrick_chromium
LGTM
9 years, 7 months ago (2011-04-28 01:30:21 UTC) #4
piman
+darin for OWNERS approval in content
9 years, 7 months ago (2011-04-28 04:32:53 UTC) #5
piman
Or brettw
9 years, 7 months ago (2011-04-28 21:18:31 UTC) #6
brettw
LGTM http://codereview.chromium.org/6883179/diff/1026/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (right): http://codereview.chromium.org/6883179/diff/1026/content/common/gpu/gpu_command_buffer_stub.cc#newcode352 content/common/gpu/gpu_command_buffer_stub.cc:352: else { Need {} for the top arm ...
9 years, 7 months ago (2011-04-28 21:21:05 UTC) #7
piman
http://codereview.chromium.org/6883179/diff/1026/content/common/gpu/gpu_command_buffer_stub.cc File content/common/gpu/gpu_command_buffer_stub.cc (right): http://codereview.chromium.org/6883179/diff/1026/content/common/gpu/gpu_command_buffer_stub.cc#newcode352 content/common/gpu/gpu_command_buffer_stub.cc:352: else { On 2011/04/28 21:21:05, brettw wrote: > Need ...
9 years, 7 months ago (2011-04-28 21:31:13 UTC) #8
jbates
9 years, 7 months ago (2011-04-28 22:36:00 UTC) #9 
On 2011/04/28 21:31:13, piman wrote:
>
http://codereview.chromium.org/6883179/diff/1026/content/common/gpu/gpu_comma...
> File content/common/gpu/gpu_command_buffer_stub.cc (right):
> 
>
http://codereview.chromium.org/6883179/diff/1026/content/common/gpu/gpu_comma...
> content/common/gpu/gpu_command_buffer_stub.cc:352: else {
> On 2011/04/28 21:21:05, brettw wrote:
> > Need {} for the top arm since you use them for the bottom.
> 
> Done.

LGTM

Powered by Google App Engine
This is Rietveld 408576698