Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Unified Diff: content/renderer/command_buffer_proxy.h

Issue 6883179: Rework FlushSync to return early if commands have been processed since the last update (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: style Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/gpu/gpu_messages.h ('k') | content/renderer/command_buffer_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/command_buffer_proxy.h
diff --git a/content/renderer/command_buffer_proxy.h b/content/renderer/command_buffer_proxy.h
index e63150c8e0a80dbd835070f986011b71f9d5e131..9cbd03301e341709801ff907edb5b7d3b64e4fdf 100644
--- a/content/renderer/command_buffer_proxy.h
+++ b/content/renderer/command_buffer_proxy.h
@@ -49,7 +49,7 @@ class CommandBufferProxy : public gpu::CommandBuffer,
virtual gpu::Buffer GetRingBuffer();
virtual State GetState();
virtual void Flush(int32 put_offset);
- virtual State FlushSync(int32 put_offset);
+ virtual State FlushSync(int32 put_offset, int32 last_known_get);
virtual void SetGetOffset(int32 get_offset);
virtual int32 CreateTransferBuffer(size_t size, int32 id_request);
virtual int32 RegisterTransferBuffer(base::SharedMemory* shared_memory,
@@ -82,14 +82,6 @@ class CommandBufferProxy : public gpu::CommandBuffer,
return last_state_;
}
- // Get the state asynchronously. The task is posted when the state is
- // updated. Takes ownership of the task object.
- void AsyncGetState(Task* completion_task);
-
- // Flush the command buffer asynchronously. The task is posted when the flush
- // completes. Takes ownership of the task object.
- void AsyncFlush(int32 put_offset, Task* completion_task);
-
private:
// Send an IPC message over the GPU channel. This is private to fully
@@ -115,10 +107,6 @@ class CommandBufferProxy : public gpu::CommandBuffer,
IPC::Channel::Sender* channel_;
int route_id_;
- // Pending asynchronous flush callbacks.
- typedef std::queue<linked_ptr<Task> > AsyncFlushTaskQueue;
- AsyncFlushTaskQueue pending_async_flush_tasks_;
-
scoped_ptr<Task> notify_repaint_task_;
scoped_ptr<Callback0::Type> swap_buffers_callback_;
« no previous file with comments | « content/common/gpu/gpu_messages.h ('k') | content/renderer/command_buffer_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698